Alon Bar-Lev has posted comments on this change.
Change subject: engine: refactor: add Model attribute for help tagging
......................................................................
Patch Set 10:
The question is if we can have all metadata in source, I just went in reverse
to make my point.
> using CommonHelpTags is not really a complexity
it is... it can be dropped without any functionality lost, nor "safety" as each
constant is used one time only.
introducing it, forces people to touch two files each modification (the actual
source and the common), it introduces merge conflicts and other undesired side
effects.
I still suggest to use plain setHelpTag("id"[, "description"]) at actual code,
dropping this common file entirely.
--
To view, visit http://gerrit.ovirt.org/21052
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
