Kanagaraj M has posted comments on this change. Change subject: webadmin : Volume Capacity UI - Part2 ......................................................................
Patch Set 9: (6 comments) http://gerrit.ovirt.org/#/c/23502/9/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java: remove this file from the patch Line 1: package org.ovirt.engine.ui.webadmin; Line 2: Line 3: import org.ovirt.engine.ui.common.CommonApplicationResources; Line 4: http://gerrit.ovirt.org/#/c/23502/9/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java: Line 25: ); could be called as volumeCapcityProgressBar http://gerrit.ovirt.org/#/c/23502/9/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java: Line 102: )); check for null and size Line 110: } Can this be an anonymous class? http://gerrit.ovirt.org/#/c/23502/9/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/WebAdmin.css File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/WebAdmin.css: Line 57: Line 58: .engine-progress-box { Line 59: border: 1px solid #AAAAAA; Line 60: width: 60%; Line 61: height: 1em; remove TWS Line 62: margin: auto; Line 63: } Line 64: Line 65: .engine-progress-box-big { Line 65: .engine-progress-box-big { Line 66: border: 1px solid #AAAAAA; Line 67: width: 150%; Line 68: height: 1em; Line 69: } is it possible to fix the width of the outer component itself? Line 70: Line 71: .engine-progress-text { Line 72: bottom: 1.3em; Line 73: text-align: center; -- To view, visit http://gerrit.ovirt.org/23502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983daf32966527cdfa7773e07aa055a24519fbe2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
