anmolbabu has posted comments on this change. Change subject: webadmin : Volume Capacity UI - Part2 ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/23502/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeCapacityRefreshCell.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeCapacityRefreshCell.java: Line 35: this.buttonDefinition = buttonDefinition; Line 36: } Line 37: Line 38: private ApplicationTemplates templates = ClientGinjectorProvider.getApplicationTemplates(); Line 39: private static CommonApplicationResources resources = GWT.create(CommonApplicationResources.class); > Done But the image and path entry corresponding to it resides in CommonApplicationResources and not in ApplicationResources. Line 40: private ApplicationMessages messages = ClientGinjectorProvider.getApplicationMessages(); Line 41: Line 42: private ActionButtonDefinition<GlusterVolumeEntity> buttonDefinition; Line 43: Line 40: private ApplicationMessages messages = ClientGinjectorProvider.getApplicationMessages(); Line 41: Line 42: private ActionButtonDefinition<GlusterVolumeEntity> buttonDefinition; Line 43: Line 44: private GlusterVolumeEntity currentSelectedItem; > is this being used? yes its used in MainTabVolumeView Line 45: Line 46: public VolumeCapacityRefreshCell() { Line 47: super("click");//$NON-NLS-1$ Line 48: } -- To view, visit http://gerrit.ovirt.org/23502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983daf32966527cdfa7773e07aa055a24519fbe2 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
