anmolbabu has posted comments on this change. Change subject: webadmin : Volume Capacity UI - Part2 ......................................................................
Patch Set 9: -Verified (6 comments) http://gerrit.ovirt.org/#/c/23502/9/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java: > remove this file from the patch Done Line 1: package org.ovirt.engine.ui.webadmin; Line 2: Line 3: import org.ovirt.engine.ui.common.CommonApplicationResources; Line 4: http://gerrit.ovirt.org/#/c/23502/9/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java: Line 21: Line 22: @Template("<div class='engine-progress-box-big'>" + Line 23: "<div style='background: {2}; width: {0}%; height: 100%'></div>" + Line 24: "<div class='engine-progress-text'>{1}</div></div>") Line 25: SafeHtml progressBarBig(int progress, String text, String color); > could be called as volumeCapcityProgressBar Done Line 26: Line 27: /** Line 28: * Creates a tree-item HTML Line 29: * http://gerrit.ovirt.org/#/c/23502/9/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java: Line 98: } Line 99: Line 100: @Override Line 101: public void onClick(List<GlusterVolumeEntity> selectedItems) { Line 102: getMainModel().setCurrentEntity(selectedItems.get(0)); > check for null and size Done Line 103: super.onClick(selectedItems); Line 104: } Line 105: Line 106: @Override Line 106: @Override Line 107: protected UICommand resolveCommand() { Line 108: return getMainModel().getRefreshVolumeCapcity(); Line 109: } Line 110: } > Can this be an anonymous class? Done Line 111: Line 112: VolumeRefreshButtonDefinition buttonDefinition = new VolumeRefreshButtonDefinition(constants.volumeCapacity()); Line 113: Line 114: refreshCell.setButtonDefinition(buttonDefinition); http://gerrit.ovirt.org/#/c/23502/9/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/WebAdmin.css File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/public/WebAdmin.css: Line 57: Line 58: .engine-progress-box { Line 59: border: 1px solid #AAAAAA; Line 60: width: 60%; Line 61: height: 1em; > remove TWS Done Line 62: margin: auto; Line 63: } Line 64: Line 65: .engine-progress-box-big { Line 65: .engine-progress-box-big { Line 66: border: 1px solid #AAAAAA; Line 67: width: 150%; Line 68: height: 1em; Line 69: } > is it possible to fix the width of the outer component itself? Tried that but didn't work.With increase in row size,the progress bar was not getting resized. Line 70: Line 71: .engine-progress-text { Line 72: bottom: 1.3em; Line 73: text-align: center; -- To view, visit http://gerrit.ovirt.org/23502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983daf32966527cdfa7773e07aa055a24519fbe2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
