Kanagaraj M has posted comments on this change. Change subject: webadmin : Volume Capacity UI - Part2 ......................................................................
Patch Set 10: (8 comments) http://gerrit.ovirt.org/#/c/23502/10/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/TimeUnitConverter.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/TimeUnitConverter.java: Line 23: Years(6 , 12); //1 year = 12 months.So,this assumes 12 * 30 = 360 days as 1 year Line 24: Line 25: private static List<Pair<TimeUnitConverter.TimeUnit, Long>> timeUnits = new ArrayList<Pair<TimeUnitConverter.TimeUnit, Long>>(); Line 26: /* Line 27: * List of triplet required because order is required and this ordering of units is independent of weight and to facilitate triplet? Line 28: * easy mapping between the triplet entities like unit name,weight and order. Line 29: */ Line 30: Line 31: private long value; http://gerrit.ovirt.org/#/c/23502/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java: Line 914: ; could be volumeEntityToRefresh http://gerrit.ovirt.org/#/c/23502/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java: Line 97: { also selectedItems.size() == 0 Line 116: }; Line 117: capacityColumn.setHorizontalAlignment(HorizontalAlignmentConstant.startOf(Direction.LTR)); Line 118: volumeCapacityCompositeList.add(capacityColumn); Line 119: Line 120: Column<GlusterVolumeEntity, GlusterVolumeEntity> capacityClockColumn = new Column<GlusterVolumeEntity, GlusterVolumeEntity>(refreshCell) { capacityRefreshColumn Line 121: @Override Line 122: public GlusterVolumeEntity getValue(GlusterVolumeEntity object) { Line 123: return object; Line 124: } http://gerrit.ovirt.org/#/c/23502/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CompositeVolumeCapacityColumn.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CompositeVolumeCapacityColumn.java: Line 11: CompositeVolumeCapacityColumn< VolumeCapacityCompositeColumn http://gerrit.ovirt.org/#/c/23502/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeCapacityCompositeCell.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeCapacityCompositeCell.java: Line 28: $ is it possible to set the width here instead of defining a new css class for the progress bar? http://gerrit.ovirt.org/#/c/23502/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeCapacityRefreshCell.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeCapacityRefreshCell.java: Line 39: CommonApplicationResources ClientGinjectorProvider().getApplicationResources() Line 40: private ApplicationMessages messages = ClientGinjectorProvider.getApplicationMessages(); Line 41: Line 42: private ActionButtonDefinition<GlusterVolumeEntity> buttonDefinition; Line 43: Line 44: private GlusterVolumeEntity currentSelectedItem; is this being used? Line 45: Line 46: public VolumeCapacityRefreshCell() { Line 47: super("click");//$NON-NLS-1$ Line 48: } -- To view, visit http://gerrit.ovirt.org/23502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983daf32966527cdfa7773e07aa055a24519fbe2 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
