Yaniv Dary has posted comments on this change. Change subject: packaging: setup: added jrs pro edition deploy steps ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/25030/7/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 580 Line 581 Line 582 Line 583 Line 584 > there is no problem with that. No it's not. the result of os.path.join('/a', '/b') is: /b See the comment I added below and test. Using os.path.join will produce only 'oreportscons.JasperEnv.SAVED_REPORTS_URI' since it starts with '/' in upstream repos. In other places in the code it will cause the beginning of the path to be lost. If I choose to drop the slash then I need to add it in places like this, since in this context (pro export) it is an absolute path. End of story, this has to be like this, since os.path.join is not good enough to catch all cases. -- To view, visit http://gerrit.ovirt.org/25030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a3f36e11d0450c031de6da6c6470024534c60e1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
