Michael Pasternak has posted comments on this change.
Change subject: rest: Add Port Mirroring to VM interface
......................................................................
Patch Set 19: (3 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2157: <xs:element ref="port_mirroring" minOccurs="0"
maxOccurs="1"/>
according to commit message:
<nic>
<network href="/api/networks/{network-id}" id="{network-id}"/>
...
<ports_mirroring>
<port_mirroring>
<network href="/api/networks/{network-id}" id="{network-id}"/>
</port_mirroring>
</ports_mirroring>
</nic>
i.e 1:N - <ports_mirroring>:<port_mirroring>, but you don't have
<ports_mirroring>
defined at all ...
(it's not number - this is entire encapsulating type - you can't add it later)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 325: optionalArguments: {nic.network.id|name: 'xs:string',
nic.name: 'xs:string', nic.port_mirroring--COLLECTION:
{port_mirroring.network.name: 'xs:string'}}
but it should be, otherwise you cant make 1:N
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java
Line 71: net.setName(entity.getNetworkName());
so change commit message .......
--
To view, visit http://gerrit.ovirt.org/3727
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d841d6d0f6cb7250a25e43bdda3d3e9b7488b
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
