Alon Bar-Lev has posted comments on this change. Change subject: aaa: Changing singletons to beans ......................................................................
Patch Set 5: (3 comments) I cannot review the j2ee magic... however two major questions... If we assume that the extension can only be used within the context of the extensions manager bean, also the invoke should happen within that context. Also, if we go this route, how will j2se service such as notification will be able to use the extension manager? I thought you will create j2ee wrapper, but enable exposure of the simple object. http://gerrit.ovirt.org/#/c/27348/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 192: return value == null ? "" : value; Line 193: } Line 194: Line 195: Line 196: all these formatting changes should probably be on separate patch and just merged http://gerrit.ovirt.org/#/c/27348/5/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionProxy.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionProxy.java: Line 33 Line 34 Line 35 Line 36 Line 37 not sure I understand... this function should be called at the context of extension manager bean, no? so you have to proxy the proxy as well... http://gerrit.ovirt.org/#/c/27348/5/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManagerLocal.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManagerLocal.java: Line 16: Logger.class, Line 17: "863db666-3ea7-4751-9695-918a3197ad83"); Line 18: public static final ExtKey CAUSE_OUTPUT_KEY = new ExtKey("EXTENSION_MANAGER_CAUSE_OUTPUT_KEY", Line 19: Throwable.class, Line 20: "894e1c86-518b-40a2-a92b-29ea1eb0403d"); these are private to this bean Line 21: Line 22: public abstract List<ExtensionProxy> getProvidedExtensions(String provides); Line 23: Line 24: public abstract ExtensionProxy getExtensionByName(String name) throws ConfigurationException; -- To view, visit http://gerrit.ovirt.org/27348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae3eeb7a487d58f59c4e75e3bf31ed10ac774142 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
