Alon Bar-Lev has posted comments on this change. Change subject: aaa: Changing singletons to beans ......................................................................
Patch Set 5: (1 comment) 2. I really think that if we go via the j2ee route we need to delegate as much as possible to the bean as if the bean can be installed remotely when we resolve the issue of the non serializable objects. 3. Each service should have its own extension manager, we wrote it detached from engine code so that this will be possible... the notification service was one of the strong candidates... http://gerrit.ovirt.org/#/c/27348/5/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManagerLocal.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManagerLocal.java: Line 16: Logger.class, Line 17: "863db666-3ea7-4751-9695-918a3197ad83"); Line 18: public static final ExtKey CAUSE_OUTPUT_KEY = new ExtKey("EXTENSION_MANAGER_CAUSE_OUTPUT_KEY", Line 19: Throwable.class, Line 20: "894e1c86-518b-40a2-a92b-29ea1eb0403d"); > i saw these two constants are used at ExtensionProxy, which is not the bean the extension proxy should live within the bean as well, so it can share the local constants. Line 21: Line 22: public abstract List<ExtensionProxy> getProvidedExtensions(String provides); Line 23: Line 24: public abstract ExtensionProxy getExtensionByName(String name) throws ConfigurationException; -- To view, visit http://gerrit.ovirt.org/27348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae3eeb7a487d58f59c4e75e3bf31ed10ac774142 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
