Yair Zaslavsky has posted comments on this change. Change subject: aaa: Changing singletons to beans ......................................................................
Patch Set 5: 1. Even comments on style, formatting , etc are welcome, this is why I do want you to look at all the files (and you do :) ) 2. Not sure why you think that invoke should be in the context of the bean - think of it as a container holding a single object (hence singleton bean) - the single object can provide you other objects you may want to invoke methods on (the extension proxy). we are not using here any other properties JEE beans may have (container managed transaction management, etc..). 3. Regarding notification service - this is an interesting question. what was your original plan? did you plan to have two extension managers (one for the engine, and one for notification service) when both engine and notification service are running? we can go of course for a wrapper suggestion like you suggested. the other option is , that if we need only one instance of extension manager for both applications, then notification service will lookup the extension manager bean. if we go for this case -will invocation of extension occur locally at notification service or remotely at engine? that is, when notification service performs "invoke" where should the "ivnocation code" run? at notification service or at engine? if these are notification extensions, I assume at notification service, so yes, we can have a wrapper, and used an "unwrapped" ExtensionManager at notification service. what do you think? -- To view, visit http://gerrit.ovirt.org/27348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae3eeb7a487d58f59c4e75e3bf31ed10ac774142 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
