Yair Zaslavsky has posted comments on this change. Change subject: aaa: Changing singletons to beans ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/27348/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 192: return value == null ? "" : value; Line 193: } Line 194: Line 195: Line 196: > all these formatting changes should probably be on separate patch and just will fix. http://gerrit.ovirt.org/#/c/27348/5/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionProxy.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionProxy.java: Line 33 Line 34 Line 35 Line 36 Line 37 > not sure I understand... this function should be called at the context of e Well, ExtensionManager bean has only local methods. I don't see a reason why I should "proxy" the invoke call. ExtensionManager bean returns you an ExtensionProxy via getExtensionByName , and you can use it with no problem. http://gerrit.ovirt.org/#/c/27348/5/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManagerLocal.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManagerLocal.java: Line 16: Logger.class, Line 17: "863db666-3ea7-4751-9695-918a3197ad83"); Line 18: public static final ExtKey CAUSE_OUTPUT_KEY = new ExtKey("EXTENSION_MANAGER_CAUSE_OUTPUT_KEY", Line 19: Throwable.class, Line 20: "894e1c86-518b-40a2-a92b-29ea1eb0403d"); > these are private to this bean i saw these two constants are used at ExtensionProxy, which is not the bean class, therefore I moved it to the interface. if you think I need to change it back - please explain. Line 21: Line 22: public abstract List<ExtensionProxy> getProvidedExtensions(String provides); Line 23: Line 24: public abstract ExtensionProxy getExtensionByName(String name) throws ConfigurationException; -- To view, visit http://gerrit.ovirt.org/27348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae3eeb7a487d58f59c4e75e3bf31ed10ac774142 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
