Shahar Havivi has posted comments on this change.
Change subject: Handle missing/invalid mac address on import Vm/Template
......................................................................
Patch Set 1: (7 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 788: String macRegex = "^(\\p{XDigit}{2}:){5}\\p{XDigit}{2}$";
Done
Line 798: if (!Regex.IsMatch(iface.getMacAddress(), macRegex)) {
please look at:
https://bugzilla.redhat.com/show_bug.cgi?id=801373
Line 927:
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
Line 345: String macRegex = "^(\\p{XDigit}{2}:){5}\\p{XDigit}{2}$";
Done
Line 372: if (StringHelper.isNullOrEmpty(iface.getMacAddress())) {
Done
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
Line 579: IMPORTEXPORT_IMPORT_INTERFACES_WITH_INVALID_MAC_ADDRESS(9602,
AuditLogTimeInterval.MINUTE.getValue()),
Done
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 500: IMPORTEXPORT_IMPORT_INTERFACES_WITH_INVALID_MAC_ADDRESS=Vm ${VmName}
have interface ${IfaceName} with invalid mac address ${MacAddress}
Done
--
To view, visit http://gerrit.ovirt.org/5290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd86a352ecc17e80dceb8c331ec38f4fa96627
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
