Eli Mesika has posted comments on this change.
Change subject: Handle missing/invalid mac address on import Vm/Template
......................................................................
Patch Set 4: (8 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 346: }
while not encapsulating the whole loop as a boolean method in
MoveOrCopyTemplateCommand since both ImportVmCommand and
ImportVmTemplateCommand inherit from it
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
Line 190: }
same
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterface.java
Line 19: public static final String VALID_MAC_ADDRESS_FORMAT =
"(\\p{XDigit}{2}:){5}\\p{XDigit}{2}";
AFAIK according to the standard a '-' separator is also valid and we have
already a requirement to support it.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 757: ACTION_TYPE_FAILED_NETWORK_INTERFACE_INVALID=Cannot ${action}
${type}. The Network Interface ${IfaceName} has an invalid MAC address
${MacAddress}. MAC address must be in format "HH:HH:HH:HH:HH:HH" where H is a
hexadecimal character (either a digit or A-F, case is insignificant).
should support '-' separator as well
....................................................
File backend/manager/modules/utils/src/test/resources/AppErrors.properties
Line 348: ACTION_TYPE_FAILED_NETWORK_INTERFACE_INVALID=Cannot ${action}
${type}. The Network Interface ${IfaceName} has an invalid MAC address
${MacAddress}. MAC address must be in format "HH:HH:HH:HH:HH:HH" where H is a
hexadecimal character (either a digit or A-F, case is insignificant).
should support '-' separator as well
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 1957: @DefaultStringValue("Cannot ${action} ${type}. The Network
Interface ${IfaceName} has an invalid MAC address ${MacAddress}. MAC address
must be in format \"HH:HH:HH:HH:HH:HH\" where H is a hexadecimal character
(either a digit or A-F, case is insignificant).")
should support '-' separator as well
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 703: ACTION_TYPE_FAILED_NETWORK_INTERFACE_INVALID=Cannot ${action}
${type}. The Network Interface ${IfaceName} has an invalid MAC address
${MacAddress}. MAC address must be in format "HH:HH:HH:HH:HH:HH" where H is a
hexadecimal character (either a digit or A-F, case is insignificant).
should support '-' separator as well
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 702: ACTION_TYPE_FAILED_NETWORK_INTERFACE_INVALID=Cannot ${action}
${type}. The Network Interface ${IfaceName} has an invalid MAC address
${MacAddress}. MAC address must be in format "HH:HH:HH:HH:HH:HH" where H is a
hexadecimal character (either a digit or A-F, case is insignificant).
should support '-' separator as well
--
To view, visit http://gerrit.ovirt.org/5290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd86a352ecc17e80dceb8c331ec38f4fa96627
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
