Mike Kolesnik has posted comments on this change.
Change subject: Handle missing/invalid mac address on import Vm/Template
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
Line 330: if (StringHelper.isNullOrEmpty(iface.getMacAddress())) {
Please do not use StringHelper, instead you can use from apache commons:
StringUtils.isEmpty()
Line 336: if (!Regex.IsMatch(iface.getMacAddress(),
VmNetworkInterface.VALID_MAC_ADDRESS_FORMAT)) {
Also please notice that the format is not fit for empty or null string, so you
might want to check StringUtils.isEmpty() before.
--
To view, visit http://gerrit.ovirt.org/5290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd86a352ecc17e80dceb8c331ec38f4fa96627
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
