Shahar Havivi has posted comments on this change.
Change subject: Handle missing/invalid mac address on import Vm/Template
......................................................................
Patch Set 3: (11 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 339: // check if mac address is valid
Done
Line 342: retVal = validateMacAddress(iface);
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
Line 183: // check if mac address is valid
Done
Line 186: retVal = validateMacAddress(iface);
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
Line 329: protected void addMissingMacAddress(VmNetworkInterface iface) {
Done
Line 330: if (StringHelper.isNullOrEmpty(iface.getMacAddress())) {
its a different issue,
if it empty we take the mac from the mac pool which is valid mac address.
the validateMcAddress() is in canDoAction() and this method is in excute
Line 336: if (!Regex.IsMatch(iface.getMacAddress(),
VmNetworkInterface.VALID_MAC_ADDRESS_FORMAT)) {
Done
Line 336: if (!Regex.IsMatch(iface.getMacAddress(),
VmNetworkInterface.VALID_MAC_ADDRESS_FORMAT)) {
Done
Line 337: AuditLogableBase logable = new AuditLogableBase();
Done
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 756: VM_IMPORT_INTERFACES_WITH_INVALID_MAC_ADDRESS=Cannot improt Vm
${VmName}. It have an interface ${IfaceName} with an invalid MAC address
${MacAddress).
Done
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 502: IMPORTEXPORT_IMPORT_INTERFACES_WITH_INVALID_MAC_ADDRESS=Cannot improt
Vm ${VmName}. It have an interface ${IfaceName} with an invalid MAC address
${MacAddress).
Done
--
To view, visit http://gerrit.ovirt.org/5290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09dd86a352ecc17e80dceb8c331ec38f4fa96627
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
