Allon Mureinik has posted comments on this change. Change subject: core: Report unreachable domain names when setting host as non operational ......................................................................
Patch Set 2: Code-Review-1 (1 comment) Liron, can you please review and make sure this aligns with the other changes you're performing in this area? http://gerrit.ovirt.org/#/c/28859/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java: Line 161: if (domainNames.length() > 0) { Line 162: domainNames.append(", "); Line 163: } Line 164: domainNames.append(domain.getStorageName()); Line 165: } This entire block can (read: should) be replaced with Entities.objectNames Line 166: customLogValues.put("StorageDomainNames", domainNames.toString()); Line 167: } Line 168: setNonOperational(NonOperationalReason.STORAGE_DOMAIN_UNREACHABLE, customLogValues); Line 169: return false; -- To view, visit http://gerrit.ovirt.org/28859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dc385da76b6a4b0776d783c0df33fa737d206c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
