Tal Nisan has posted comments on this change.

Change subject: core: Report unreachable domain names when setting host as non 
operational
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/28859/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java:

Line 1398:                                             .vdsNonOperational(vdsId,
Line 1399:                                                     
NonOperationalReason.STORAGE_DOMAIN_UNREACHABLE,
Line 1400:                                                     true,
Line 1401:                                                     domainId,
Line 1402:                                                     
Collections.singletonMap("storageDomainNames", storageDomain.getStorageName()));
> In that case the audit log may be a bit misleading as the host may have pro
What do you suggest?
Line 1403:                                 }
Line 1404:                             });
Line 1405: 
Line 1406:                             nonOpVdss.add(vdsId);


-- 
To view, visit http://gerrit.ovirt.org/28859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dc385da76b6a4b0776d783c0df33fa737d206c0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to