Yair Zaslavsky has posted comments on this change.
Change subject: Adding bios information to vds object
......................................................................
Patch Set 13: (2 inline comments)
1. Regarding hashCode and equals - Yaniv is right, for some reason I did not
see the definition at VdsStatic
2. Regarding VdsDyanmic vs VdsStatic - we talked about this issue with Eli as
well. VdsStatic should not contain information that is changed only by UI , but
also information that does not change on high frequent basic. We should revisit
all fields of vds static and dynamic.
3. Regarding new VDSM API - Actually I was against that, but after discussion
on vdsm-devel (with Adam Litke, Barak Azulay and others) it was decided that
getCaps is becoming "too crowded".
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
Line 106: } else if (!mNetworkList.equals(other.mNetworkList))
Line 107: return false;
Line 108: if (mVdsStatic == null) {
Line 109: if (other.mVdsStatic != null)
Line 110: return false;
you are correct. My mistake.
Line 111: } else if (!mVdsStatic.equals(other.mVdsStatic))
Line 112: return false;
Line 113: if (max_vds_memory_over_commitField !=
other.max_vds_memory_over_commitField)
Line 114: return false;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
Line 122: private ValueObjectMap pmOptionsMap;
Line 123:
Line 124: @Column(name = "otp_validity")
Line 125: private long otpValidity;
Line 126:
My mistake.
Line 127: @Min(BusinessEntitiesDefinitions.HOST_MIN_SPM_PRIORITY)
Line 128: @Max(BusinessEntitiesDefinitions.HOST_MAX_SPM_PRIORITY)
Line 129: @Column(name = "vds_spm_priority")
Line 130: private int vdsSpmPriority;
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
