Yaniv Bronhaim has posted comments on this change.
Change subject: Adding bios information to vds object
......................................................................
Patch Set 16: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 517: new VdsIdAndVdsVDSCommandParametersBase(vds));
Line 518: if
(!vdsBrokerCommand.getVDSReturnValue().getSucceeded()) {
Line 519: setIsSetNonOperationalExecuted(true);
Line 520: }
Line 521: UpdateDynamicData(vds.getDynamicData());
yes, otherwise we don't update the db, only local vds object is changed and
here we update db only after exception.
I can move it to be as part of the command, but it seems like the "Manager"
should connect between the vds and db.
Line 522: }
Line 523:
Line 524: VDSStatus returnStatus = vds.getstatus();
Line 525: boolean isSetNonOperational =
CollectVdsNetworkDataVDSCommand.persistAndEnforceNetworkCompliance(vds);
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
