Omer Frenkel has posted comments on this change.
Change subject: Adding bios information to vds object
......................................................................
Patch Set 15: (1 inline comment)
there is a little mess in this patch,
the change to ConfigValues enum should be in previous patch,
and i can't find the implementation to the new VDS command
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 527: if (Config.<Boolean>
GetValue(ConfigValues.BiosInfoEnabled, vds.getvds_group_compatibility_version()
Line 528: .getValue())) {
Line 529: GetBiosInfoVDSCommand vdsBiosCommand = new
GetBiosInfoVDSCommand(
Line 530: new VdsIdAndVdsVDSCommandParametersBase(vds));
Line 531: vdsBiosCommand.Execute();
please use factory to run the command instead of creating an instance,
also, where is it defined?
Line 532: if
(!vdsBrokerCommand.getVDSReturnValue().getSucceeded()) {
Line 533: setIsSetNonOperationalExecuted(true);
Line 534: }
Line 535: updateStaticData(vds.getStaticData(),
oldVDS.getStaticData());
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
