Liron Aravot has posted comments on this change.
Change subject: Adding bios information to vds object
......................................................................
Patch Set 17: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 515: .getValue())) {
Line 516:
ResourceManager.getInstance().runVdsCommand(VDSCommandType.GetBiosInfo,
Line 517: new VdsIdAndVdsVDSCommandParametersBase(vds));
Line 518: if
(!vdsBrokerCommand.getVDSReturnValue().getSucceeded()) {
Line 519: setIsSetNonOperationalExecuted(true);
you set here setIsSetNonOperationalExecuted(true) and then in line 524
the CollectVdsNetworkDataVDSCommand.persistAndEnforceNetworkCompliance is still
executed anyway
seems to me that you don't need to execute the method on line 524 if you know
that you want to set to non operational...no?
Line 520: }
Line 521: }
Line 522:
Line 523: VDSStatus returnStatus = vds.getstatus();
Line 532:
"refreshCapabilities:GetCapabilitiesVDSCommand vds {0} networks not match it's
cluster networks, vds will be moved to NonOperational",
Line 533: vds.getStaticData().getId());
Line 534: }
Line 535: vds.setstatus(VDSStatus.NonOperational);
Line 536:
vds.setNonOperationalReason(NonOperationalReason.NETWORK_UNREACHABLE);
general question - no need to add non operational reason for bios info as well?
Line 537: returnStatus = vds.getstatus();
Line 538: }
Line 539:
Line 540: // We process the software capabilities.
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
