Omer Frenkel has posted comments on this change.
Change subject: Adding bios information to vds object
......................................................................
Patch Set 19: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 531: }
Line 532:
Line 533: if (isSetNonOperational && returnStatus !=
VDSStatus.NonOperational) {
Line 534: if (log.isDebugEnabled()) {
Line 535: log.debugFormat(
this is wrong, the "NETWORK_UNREACHABLE" reason is specific for missing
network, if bios info fails it needs its own treatment:
1. ignore it if its not critical for the host operation (== just log an error
and host will continue as nothing happened)
2. create new non-operational reason and add treatment for it
3. act the same as get-capabilities failure (look at 'else' part, an exception
is thrown
Line 536:
"refreshCapabilities:GetCapabilitiesVDSCommand vds {0} networks not match it's
cluster networks, vds will be moved to NonOperational",
Line 537: vds.getStaticData().getId());
Line 538: }
Line 539: vds.setstatus(VDSStatus.NonOperational);
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
