Juan Hernandez has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/console/ConsoleConfigServlet.java
Line 39: private void writeConfigFileHeader(HttpServletResponse response)
throws IOException {
Line 40: PrintWriter writer = response.getWriter();
Line 41:
Line 42: writer.println(CONFIG_FILE_HEADER);
Line 43: if (writer.checkError()) {
It is needed if you want to report IO errors generated while calling the
"writer.println(...)" methods, as they don't throw any exception. Chances of IO
errors doing this are really low, but it doesn't hurt to report them.
Line 44: throw new IOException("Error when writing to response
stream");
Line 45: }
Line 46:
Line 47: writer.flush();
--
To view, visit http://gerrit.ovirt.org/11702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
