Alon Bar-Lev has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/console/ConsoleConfigServlet.java
Line 39: private void writeConfigFileHeader(HttpServletResponse response)
throws IOException {
Line 40: PrintWriter writer = response.getWriter();
Line 41:
Line 42: writer.println(CONFIG_FILE_HEADER);
Line 43: if (writer.checkError()) {
So what you basically say is that all sevlets in the world are written with the
option to partially write data as they do not check this flag after *EACH*
write.
I also found some references that this is completely void, example:
https://forums.oracle.com/forums/thread.jspa?threadID=746556
http://stackoverflow.com/questions/520348/servlet-long-processing-cancelation-when-browser-closes
or the strange note at:
http://docstore.mik.ua/orelly/java-ent/servlet/ch05_07.htm
Line 44: throw new IOException("Error when writing to response
stream");
Line 45: }
Line 46:
Line 47: writer.flush();
--
To view, visit http://gerrit.ovirt.org/11702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
