Yaniv Bronhaim has posted comments on this change. Change subject: getAllTasksList\Status with spUUID retrieves info only if host is the SPM ......................................................................
Patch Set 2: Vdsm doesn't have SPM and HSM command, all API does not depend on the host's status. The api request for getAllTasksList needs to include the spUUID to retrieve SPM tasks (otherwise vdsm can't validate the spm status) And the way to pass more parameters to the request is by adding to VdsServerProxy.getAllTasksList. This solution is part of vdsm part and this patch adds the sp id to the request. It's not a workaround in engine side, its a change in the API for SPM requests to allow vdsm to do validation for spm status and handling the request for tasks in the same bit. We don't want new API or validation in engine side, we want to keep the request as is, and if the spUUID is passed engine should get back exception if the host is not spm. -- To view, visit http://gerrit.ovirt.org/13450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff7d8db4e4ad6b3f809085aff7216ac8a457b633 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: liron aravot <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
