Yair Zaslavsky has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetAllTasksInfoVDSCommand.java
Line 6: import org.ovirt.engine.core.utils.log.Log;
Line 7: import org.ovirt.engine.core.utils.log.LogFactory;
Line 8: import org.ovirt.engine.core.vdsbroker.ResourceManager;
Line 9:
Line 10: public class SPMGetAllTasksInfoVDSCommand<P extends
IrsBaseVDSCommandParameters> extends IrsBrokerCommand<P> {
The existence of this class is ugly and misleading.
Can't we avoid having this class? We have some duplication in the code, as
stated by kublin with the HSMGetAllTasksInfoVDSCommand.
It will be great if we take care of this issue on the way, even if as cleanup
patch that precedes to this one.
Line 11: public SPMGetAllTasksInfoVDSCommand(P parameters) {
Line 12: super(parameters);
Line 13: }
Line 14:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetAllTasksStatusesVDSCommand.java
Line 12: import org.ovirt.engine.core.utils.log.Logged.LogLevel;
Line 13: import org.ovirt.engine.core.vdsbroker.xmlrpc.XmlRpcStruct;
Line 14:
Line 15: @Logged(executionLevel = LogLevel.DEBUG)
Line 16: public class HSMGetAllTasksStatusesVDSCommand<P extends
SpIdVDSCommandParametersBase> extends VdsBrokerCommand<P> {
See previous comment.
Line 17: private TaskStatusListReturnForXmlRpc _result;
Line 18:
Line 19: public HSMGetAllTasksStatusesVDSCommand(P parameters) {
Line 20: super(parameters);
--
To view, visit http://gerrit.ovirt.org/13450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff7d8db4e4ad6b3f809085aff7216ac8a457b633
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
