Michael Kublin has posted comments on this change. Change subject: getAllTasksList\Status with spUUID retrieves info only if host is the SPM ......................................................................
Patch Set 2: "why getAllTaskstatuses is used as HSM and SPM command in engine side" "You can ask it in the bugzilla page." - Actually not, the purpose of bugzilla is not to explain or ask why we have two classes: HSMGetAllTasksStatusesVDSCommand and SPMGetAllTasksStatusesVDSCommand when second calling a first, and second is used in two places and in one place 100% it is used in a wrong way. "It doesn't change the logic of polling the tasks or the way engine uses this API" - this is not related, I am asking to write an understandable code. . Now, I wrote more than once what I am advising, you can read, I don't see reason to write it is in a third time. -- To view, visit http://gerrit.ovirt.org/13450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff7d8db4e4ad6b3f809085aff7216ac8a457b633 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: liron aravot <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
