Maor Lipchuk has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetAllTasksInfoVDSCommand.java
Line 32: ProceedProxyReturnValue();
Line 33: setReturnValue(parseTaskInfoList(result.TaskInfoList));
Line 34: }
Line 35:
Line 36: private List<AsyncTaskCreationInfo> parseTaskInfoList(Map<String,
Map<String, String>> taskInfoList) {
I think this method can be delcared static since there is no instance which its
state is being changed here
Line 37: try {
Line 38: List<AsyncTaskCreationInfo> result = new
ArrayList<AsyncTaskCreationInfo>(taskInfoList.size());
Line 39: for (Map.Entry<String, Map<String, String>> entry :
taskInfoList.entrySet()) {
Line 40: Guid taskID = new Guid(entry.getKey());
Line 57: try {
Line 58: taskType = AsyncTaskType.valueOf(parsedType);
Line 59: } catch (IllegalArgumentException e) {
Line 60: taskType = AsyncTaskType.unknown;
Line 61: log.warn("The task type in the vdsm response is " +
parsedType
Better to use warnFormat as follow:
log.warnFormat("The task type in the vdsm response is {0} and does not appear
in the AsyncTaskType enum", deTaskType)
Line 62: + " and does not appear in the AsyncTaskType
enum");
Line 63: throw e;
Line 64: } catch (NullPointerException e) {
Line 65: log.error(String.format(
--
To view, visit http://gerrit.ovirt.org/13450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff7d8db4e4ad6b3f809085aff7216ac8a457b633
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
