Allon Mureinik has posted comments on this change. Change subject: engine: Added new canDoAction check for gluster ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) You need to add the message in all the locations of AppErrors.properties. Please see http://www.ovirt.org/Engine_Adding_Messages .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java Line 348: Line 349: try { Line 350: if(serverHasPeers()) { Line 351: addCanDoActionMessage(VdcBllMessages.SERVER_ALREADY_PART_OF_ANOTHER_CLUSTER); Line 352: returnValue = false; you can inline this with returnValue = failCanDoAction(VdcBllMessages.SERVER_ALREADY_PART_OF_ANOTHER_CLUSTER); Line 353: } Line 354: } catch (AuthenticationException e) { Line 355: addCanDoActionMessage(VdcBllMessages.SSH_AUTHENTICATION_FAILED); Line 356: returnValue = false; Line 352: returnValue = false; Line 353: } Line 354: } catch (AuthenticationException e) { Line 355: addCanDoActionMessage(VdcBllMessages.SSH_AUTHENTICATION_FAILED); Line 356: returnValue = false; same here Line 357: } Line 358: } Line 359: return returnValue; Line 360: } -- To view, visit http://gerrit.ovirt.org/13980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81427fa940bf1edabf316acebc428becac0171f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
