Alon Bar-Lev has posted comments on this change.
Change subject: engine: Added new canDoAction check for gluster
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
+1 for the ssh part.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 82: @Override
Line 83: protected void setActionMessageParameters() {
Line 84: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__ADD);
Line 85: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__HOST);
Line 86: addCanDoActionMessage(String.format("$server %1$s",
getParameters().getvds().getHostName()));
OK... this mechanism is way too complex for me :)
Thanks!
Line 87: }
Line 88:
Line 89: @Override
Line 90: protected void executeCommand() {
--
To view, visit http://gerrit.ovirt.org/13980
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81427fa940bf1edabf316acebc428becac0171f8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Vijay Bellur <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
