Allon Mureinik has posted comments on this change.
Change subject: engine: Added new canDoAction check for gluster
......................................................................
Patch Set 2: Looks good to me, approved
(1 inline comment)
Just fix (or address) the inline comment in the test and rebase, and as far as
I'm concerned, we're good to go
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsCommandTest.java
Line 67: parameters.setvds(newVds);
Line 68: }
Line 69:
Line 70: @Before
Line 71: public void setUp() {
So why do you need the the setUp() method? Just put @Before on
createParameters()
Line 72: createParameters();
Line 73: }
Line 74:
Line 75: private void setupCommonMock(boolean glusterEnabled) throws
Exception {
--
To view, visit http://gerrit.ovirt.org/13980
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81427fa940bf1edabf316acebc428becac0171f8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Vijay Bellur <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
