Shireesh Anjal has posted comments on this change.
Change subject: engine: Added new canDoAction check for gluster
......................................................................
Patch Set 1: (3 inline comments)
Thanks Alon, will use the same sshclient object which is currently being used
in canConnect()
Allon,
- Will use failCanDoAction.
- If you are referring to adding the message in userportal-gwtp module as well,
I believe it is not required any more, as the annotation @DefaultStringValue in
AppErrors.java takes care of it. The wiki page probably needs an update.
New patch-set to follow with agreed code changes.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 346: }
Line 347: }
Line 348:
Line 349: try {
Line 350: if(serverHasPeers()) {
Sure, I will make changes to use the same sshclient object.
Line 351:
addCanDoActionMessage(VdcBllMessages.SERVER_ALREADY_PART_OF_ANOTHER_CLUSTER);
Line 352: returnValue = false;
Line 353: }
Line 354: } catch (AuthenticationException e) {
Line 348:
Line 349: try {
Line 350: if(serverHasPeers()) {
Line 351:
addCanDoActionMessage(VdcBllMessages.SERVER_ALREADY_PART_OF_ANOTHER_CLUSTER);
Line 352: returnValue = false;
Done
Line 353: }
Line 354: } catch (AuthenticationException e) {
Line 355:
addCanDoActionMessage(VdcBllMessages.SSH_AUTHENTICATION_FAILED);
Line 356: returnValue = false;
Line 352: returnValue = false;
Line 353: }
Line 354: } catch (AuthenticationException e) {
Line 355:
addCanDoActionMessage(VdcBllMessages.SSH_AUTHENTICATION_FAILED);
Line 356: returnValue = false;
Done
Line 357: }
Line 358: }
Line 359: return returnValue;
Line 360: }
--
To view, visit http://gerrit.ovirt.org/13980
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81427fa940bf1edabf316acebc428becac0171f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
