Yair Zaslavsky has posted comments on this change.
Change subject: Adding parameters to delay fence based on host's load
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
Please introduce config changes to
pre_upgrade/0000_config.sql
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1358:
Line 1359: @Reloadable
Line 1360: @TypeConverterAttribute(Double.class)
Line 1361: @DefaultValueAttribute("10")
Line 1362: DelayResetPerStatusInSeconds(503),
Why not "ForSpm" incstead of 'PerStatus"?
Line 1363:
Line 1364: @Reloadable
Line 1365: @TypeConverterAttribute(Double.class)
Line 1366: @DefaultValueAttribute("3")
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 593:
log.errorFormat("refreshCapabilities:GetCapabilitiesVDSCommand failed with no
exception!");
Line 594: throw new
RuntimeException(vdsBrokerCommand.getVDSReturnValue().getExceptionString());
Line 595: }
Line 596: }
Line 597:
s/Integer/int
Line 598: private double calcTimeoutToFence(Integer vmCount, VdsSpmStatus
spmStatus) {
Line 599: Integer spmIndicator = 0;
Line 600: if (spmStatus == VdsSpmStatus.SPM) {
Line 601: spmIndicator = 1;
Line 595: }
Line 596: }
Line 597:
Line 598: private double calcTimeoutToFence(Integer vmCount, VdsSpmStatus
spmStatus) {
Line 599: Integer spmIndicator = 0;
s/Integer/int
Line 600: if (spmStatus == VdsSpmStatus.SPM) {
Line 601: spmIndicator = 1;
Line 602: }
Line 603: return TimeUnit.SECONDS.toMillis(
--
To view, visit http://gerrit.ovirt.org/14288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69c15b254cb5323416aaa33756866218870056d2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
