Maor Lipchuk has posted comments on this change.
Change subject: Adding parameters to delay fence based on host's load
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1356: @DefaultValueAttribute("false")
Line 1357: MigrationNetworkEnabled(502),
Line 1358:
Line 1359: @Reloadable
Line 1360: @TypeConverterAttribute(Double.class)
I think that u can use Integer here and also at the other parameter.
Probably customers will not configure fracture of seconds.
Line 1361: @DefaultValueAttribute("10")
Line 1362: DelayResetForSpmInSeconds(503),
Line 1363:
Line 1364: @Reloadable
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 602: }
Line 603: return TimeUnit.SECONDS.toMillis(
Line 604: Config.<Integer>
GetValue(ConfigValues.TimeoutToResetVdsInSeconds) +
Line 605: (Config.<Integer>
GetValue(ConfigValues.DelayResetForSpmInSeconds) * spmIndicator) +
Line 606: (Config.<Integer>
GetValue(ConfigValues.DelayResetPerVmInSeconds) * vmCount));
You use Integer here but this field is configured as double
Line 607: }
Line 608: /**
Line 609: * Handle network exception, return true if save vdsDynamic to DB
is needed.
Line 610: *
--
To view, visit http://gerrit.ovirt.org/14288
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69c15b254cb5323416aaa33756866218870056d2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
