Yair Zaslavsky has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
......................................................................
Patch Set 10: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetTaskListCommandParameters.java
Line 4: import org.ovirt.engine.core.compat.Version;
Line 5:
Line 6: public class GetTaskListCommandParameters extends
VdsIdVDSCommandParametersBase {
Line 7:
Line 8: private Guid StoragePoolId;
camel case, please.
stroagePoolId.
And also, should be compatbilityVersion, and not storagePoolCompability version
(change getter/setter as well).
Line 9: private Version StoragePoolCompatibilityVersion;
Line 10:
Line 11: public GetTaskListCommandParameters() {
Line 12: StoragePoolId = null;
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 1626: protected void ExecuteIrsBrokerCommand() {
Line 1627: }
Line 1628:
Line 1629: protected Version getStoragePoolClusterLevel(Guid StoragePoolId)
{
Line 1630: StoragePool storagePool =
DbFacade.getInstance().getStoragePoolDao().get(StoragePoolId);
Would be awesome if you add a method of getStoragePoolDao() that will return
DbFacade.getInstance().getStoragePoolDao.
I promised you an explanation on why , and I will provide it (it will make
mocking life easier, and a better step towards Dependency injection).
Line 1631: if (storagePool != null) {
Line 1632: return storagePool.getcompatibility_version();
Line 1633: } else {
Line 1634: log.errorFormat(
--
To view, visit http://gerrit.ovirt.org/13450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff7d8db4e4ad6b3f809085aff7216ac8a457b633
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
