Omer Frenkel has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
......................................................................
Patch Set 9: (3 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetAllTasksInfoVDSCommand.java
Line 19: @Override
Line 20: protected void ExecuteVdsBrokerCommand() {
Line 21: boolean isFilled = false;
Line 22: if (getParameters().getStoragePoolId() != null) {
Line 23: if
(FeatureSupported.saferGetAllTasksRequest(getVds().getVdsGroupCompatibilityVersion()))
{
does it make sense to send 2 versions of the verb to different hosts in the
data center? (if one is older than 3.3 and other is 3.3)
i think you should use storage pool compatibility to be consistent with all
hosts in the storage pool.
Line 24: _result =
getBroker().getAllTasksInfo(getParameters().getStoragePoolId().toString());
Line 25: isFilled = true;
Line 26: }
Line 27: }
Line 26: }
Line 27: }
Line 28: if (!isFilled) {
Line 29: _result = getBroker().getAllTasksInfo();
Line 30: }
why making the code complicated with "isFilled"?
just a suggestion:
if (getParameters().getStoragePoolId() != null &&
FeatureSupported.saferGetAllTasksRequest(getVds().getVdsGroupCom
patibilityVersion())) {
_result = getBroker().getAllTasksInfo(getParameters().getStorage
PoolId().toString());
} else {
_result = getBroker().getAllTasksInfo();
}
Line 31:
Line 32: ProceedProxyReturnValue();
Line 33: setReturnValue(ParseTaskInfoList(_result.TaskInfoList));
Line 34: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetAllTasksStatusesVDSCommand.java
Line 31: }
Line 32: }
Line 33: if (!isFilled) {
Line 34: _result = getBroker().getAllTasksStatuses();
Line 35: }
same comments here
Line 36:
Line 37: ProceedProxyReturnValue();
Line 38: setReturnValue(ParseTaskStatusList(_result.TaskStatusList));
Line 39: }
--
To view, visit http://gerrit.ovirt.org/13450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff7d8db4e4ad6b3f809085aff7216ac8a457b633
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
