Yair Zaslavsky has posted comments on this change.
Change subject: core: Persist all async task place holders
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 302: }
Line 303:
Line 304: private boolean actionAllowed = false;
Line 305:
Line 306: protected void checkCanDoAction() {
Ravi, what do you think? I looked again at the code, do we still need to have
this division?
Line 307: actionAllowed = getReturnValue().getCanDoAction() ||
internalCanDoAction();
Line 308: }
Line 309:
Line 310: public VdcReturnValueBase executeAction() {
--
To view, visit http://gerrit.ovirt.org/15561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66628b98298ed1f500946889604ad906f0a68022
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
