Ravi Nori has posted comments on this change.
Change subject: core: Persist all async task place holders
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1259: * @param runAsInternal
Line 1260: * @param context
Line 1261: * @return
Line 1262: */
Line 1263: protected CommandBase<?> constructCommand(VdcActionType
actionType,
Backend.getInstance() returns BackendInternal which extends BackendLocal
I guess if we put it in BackendInternal the createCommand method wont be
exposed outside bll. If we need to move it to Backend, we should keep it in
BackendInternal and not BackendLocal
Line 1264: VdcActionParametersBase parameters,
Line 1265: boolean runAsInternal,
Line 1266: CommandContext context) {
Line 1267: ExecutionHandler.evaluateCorrelationId(parameters);
--
To view, visit http://gerrit.ovirt.org/15561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66628b98298ed1f500946889604ad906f0a68022
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
