Yair Zaslavsky has posted comments on this change.

Change subject: 5. core: Persist all async task place holders
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1339:     }
Line 1340: 
Line 1341:     Map<String, Guid> taskKeyToTaskIdMap = new HashMap<>();
Line 1342: 
Line 1343:     public void persistAsyncTaskPlaceHolder(VdcActionType 
parentCommand) {
Isn't this the patch where deleteAsyncTaskPlaceHolder should be introduced at?
Line 1344:         persistAsyncTaskPlaceHolder(parentCommand, DEFAULT_TASK_KEY);
Line 1345:     }
Line 1346: 
Line 1347:     public void persistAsyncTaskPlaceHolder(VdcActionType 
parentCommand, String taskKey) {


-- 
To view, visit http://gerrit.ovirt.org/15561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66628b98298ed1f500946889604ad906f0a68022
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to