Allon Mureinik has posted comments on this change.
Change subject: 5. core: Persist all async task place holders
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(4 inline comments)
I'm probably missing something, but again, you have a reoccurring pattern:
persistAsyncTaskPlaceHolder(...);
Guid taskId = getAsyncTaskId();
Why can't persistAsyncTaskPlaceHolder return the task ID?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 300: getReturnValue().setDescription((tempVar != null) ? tempVar :
getReturnValue().getDescription());
Line 301: return _returnValue;
Line 302: }
Line 303:
Line 304: private boolean actionAllowed = false;
why do you need this as a member?
Line 305:
Line 306: protected void checkCanDoAction() {
Line 307: actionAllowed = getReturnValue().getCanDoAction() ||
internalCanDoAction();
Line 308: }
Line 1363: deleteAsyncTaskPlaceHolder(DEFAULT_TASK_KEY);
Line 1364: }
Line 1365:
Line 1366: public void deleteAsyncTaskPlaceHolder(String taskKey) {
Line 1367: if (!taskKeyToTaskIdMap.containsKey(taskKey)) {
This check is redundant.
Just call taskKeyToTaskIdMap.remove(taskKey), and check if it returns null or
not
Line 1368: return;
Line 1369: }
Line 1370: Guid taskId = taskKeyToTaskIdMap.remove(taskKey);
Line 1371: AsyncTaskManager.removeTaskFromDbByTaskId(taskId);
....................................................
Commit Message
Line 6:
Line 7: 5. core: Persist all async task place holders
Line 8:
Line 9: Add the infra structure code for persisiting
Line 10: all async task place holder for all child commands
s/place holder/placeholder/
Line 11: before submitting any task to vdsm
Line 12:
Line 13: Change-Id: I66628b98298ed1f500946889604ad906f0a68022
Line 8:
Line 9: Add the infra structure code for persisiting
Line 10: all async task place holder for all child commands
Line 11: before submitting any task to vdsm
Line 12:
Please add a link to the feature page
Line 13: Change-Id: I66628b98298ed1f500946889604ad906f0a68022
--
To view, visit http://gerrit.ovirt.org/15561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66628b98298ed1f500946889604ad906f0a68022
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
