Itamar Heim has posted comments on this change.
Change subject: core: Initial support for alternative architectures
......................................................................
Patch Set 2: (5 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/strategy/ArchStrategy.java
Line 53: }
Line 54:
Line 55: public int getDefaultOs() {
Line 56: return this.architecture.getDefaultOS();
Line 57: }
how/where is this used? i couldn't find in osinfo any prop for this? is it
needed?
Line 58:
Line 59: public boolean isVdsGroupCompatible(VDSGroup vdsGroup) {
Line 60: return isCPUCompatible(vdsGroup.getcpu_name(),
vdsGroup.getcompatibility_version());
Line 61: }
....................................................
Commit Message
Line 18: The CpuFlagsManagerHandler and the ServerCpuList table were changed
Line 19: to support the POWER 7 architecture.
Line 20:
Line 21: The OS repository was modified to handle the architecture of each OS
Line 22: and provide information about supported displays and architectures.
considering the other os properties are lists, I wonder if instead of
spiceSupport=true|false, it shouldn't be supportedDisplayProtocols=vnc[,spice]
to be more generic
Line 23:
Line 24: The clusters, templates and VMs business entities were changed to
Line 25: include a field indicating their target architecture.
Line 26:
....................................................
File packaging/dbscripts/create_views.sql
Line 564: vm_statistics.elapsed_time as elapsed_time,
vm_statistics.usage_network_percent as usage_network_percent,
Line 565: vm_statistics.usage_mem_percent as
usage_mem_percent, vm_statistics.usage_cpu_percent as usage_cpu_percent,
vds_static.vds_name as run_on_vds_name, vds_groups.cpu_name as
vds_group_cpu_name,
Line 566: vm_static.default_display_type as
default_display_type, vm_static.priority as priority,vm_static.iso_path as
iso_path, vm_static.origin as origin, vds_groups.compatibility_version as
vds_group_compatibility_version,
Line 567: vm_static.initrd_url as initrd_url,
vm_static.kernel_url as kernel_url, vm_static.kernel_params as kernel_params,
vm_dynamic.pause_status as pause_status, vm_dynamic.exit_message as
exit_message, vm_dynamic.exit_status as exit_status,vm_static.migration_support
as migration_support,vm_static.predefined_properties as
predefined_properties,vm_static.userdefined_properties as
userdefined_properties,vm_static.min_allocated_mem as min_allocated_mem,
vm_dynamic.hash as hash, vm_static.cpu_pinning as cpu_pinning,
vm_static.db_generation as db_generation, vm_static.host_cpu_flags as
host_cpu_flags,
Line 568: vm_static.tunnel_migration as tunnel_migration,
vm_static.vnc_keyboard_layout as vnc_keyboard_layout,
vm_static.is_run_and_pause as is_run_and_pause, vm_static.created_by_user_id as
created_by_user_id, vm_static.architecture_name as architecture_name,
white space noise
Line 569: vm_dynamic.last_watchdog_event as
last_watchdog_event, vm_dynamic.last_watchdog_action as last_watchdog_action
Line 570: FROM vm_static INNER JOIN
Line 571: vm_dynamic ON vm_static.vm_guid = vm_dynamic.vm_guid INNER JOIN
Line 572: vm_static AS vm_templates ON vm_static.vmt_guid =
vm_templates.vm_guid INNER JOIN
....................................................
File packaging/dbscripts/upgrade/03_03_0400_add_architecture_name_column.sql
Line 2: select fn_db_add_column('vds_groups', 'architecture_name',
'VARCHAR(40)');
Line 3: select fn_db_add_column('vm_static', 'architecture_name',
'VARCHAR(40)');
Line 4:
Line 5: -- Existent clusters with cpu_name are x86_64, since power is being
introduced now
Line 6: UPDATE vds_groups SET architecture_name = 'x86_64' where cpu_name is
not NULL;
and architecture_name is null?
Line 7:
Line 8: -- Existent VMs and templates are also x86_64, for the same reason
Line 9: UPDATE vm_static SET architecture_name = 'x86_64';
Line 5: -- Existent clusters with cpu_name are x86_64, since power is being
introduced now
Line 6: UPDATE vds_groups SET architecture_name = 'x86_64' where cpu_name is
not NULL;
Line 7:
Line 8: -- Existent VMs and templates are also x86_64, for the same reason
Line 9: UPDATE vm_static SET architecture_name = 'x86_64';
where architecture_name is null?
(safe guard for a rerun of the script?
--
To view, visit http://gerrit.ovirt.org/16700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33ed9231a6467aa59e8f3223ba9d61b6e68039fa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
