Itamar Heim has posted comments on this change.
Change subject: core: Initial support for alternative architectures
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 419: select fn_db_add_config_value('SendVmTicketUID','true','3.3');
Line 420: select fn_db_add_config_value('ServerCPUList','3:Intel Conroe
Family:vmx,nx,model_Conroe:Conroe:x86_64; 4:Intel Penryn
Family:vmx,nx,model_Penryn:Penryn:x86_64; 5:Intel Nehalem
Family:vmx,nx,model_Nehalem:Nehalem:x86_64; 6:Intel Westmere
Family:aes,vmx,nx,model_Westmere:Westmere:x86_64; 2:AMD Opteron
G1:svm,nx,model_Opteron_G1:Opteron_G1:x86_64; 3:AMD Opteron
G2:svm,nx,model_Opteron_G2:Opteron_G2:x86_64; 4:AMD Opteron
G3:svm,nx,model_Opteron_G3:Opteron_G3:x86_64;','3.0');
Line 421: select fn_db_add_config_value('ServerCPUList','3:Intel Conroe
Family:vmx,nx,model_Conroe:Conroe:x86_64; 4:Intel Penryn
Family:vmx,nx,model_Penryn:Penryn:x86_64; 5:Intel Nehalem
Family:vmx,nx,model_Nehalem:Nehalem:x86_64; 6:Intel Westmere
Family:aes,vmx,nx,model_Westmere:Westmere:x86_64; 2:AMD Opteron
G1:svm,nx,model_Opteron_G1:Opteron_G1:x86_64; 3:AMD Opteron
G2:svm,nx,model_Opteron_G2:Opteron_G2:x86_64; 4:AMD Opteron
G3:svm,nx,model_Opteron_G3:Opteron_G3:x86_64;','3.1');
Line 422: select fn_db_add_config_value('ServerCPUList','3:Intel Conroe
Family:vmx,nx,model_Conroe:Conroe:x86_64; 4:Intel Penryn
Family:vmx,nx,model_Penryn:Penryn:x86_64; 5:Intel Nehalem
Family:vmx,nx,model_Nehalem:Nehalem:x86_64; 6:Intel Westmere
Family:aes,vmx,nx,model_Westmere:Westmere:x86_64; 7:Intel SandyBridge
Family:vmx,nx,model_SandyBridge:SandyBridge:x86_64; 8:Intel
Haswell:vmx,nx,model_Haswell:Haswell:x86_64; 2:AMD Opteron
G1:svm,nx,model_Opteron_G1:Opteron_G1:x86_64; 3:AMD Opteron
G2:svm,nx,model_Opteron_G2:Opteron_G2:x86_64; 4:AMD Opteron
G3:svm,nx,model_Opteron_G3:Opteron_G3:x86_64; 5:AMD Opteron
G4:svm,nx,model_Opteron_G4:Opteron_G4:x86_64; 6:AMD Opteron
G5:smx,nx,model_Opteron_G5:Opteron_G5:x86_64;','3.2');
Line 423: select fn_db_add_config_value('ServerCPUList','3:Intel Conroe
Family:vmx,nx,model_Conroe:Conroe:x86_64; 4:Intel Penryn
Family:vmx,nx,model_Penryn:Penryn:x86_64; 5:Intel Nehalem
Family:vmx,nx,model_Nehalem:Nehalem:x86_64; 6:Intel Westmere
Family:aes,vmx,nx,model_Westmere:Westmere:x86_64; 7:Intel SandyBridge
Family:vmx,nx,model_SandyBridge:SandyBridge:x86_64; 8:Intel
Haswell:vmx,nx,model_Haswell:Haswell:x86_64; 2:AMD Opteron
G1:svm,nx,model_Opteron_G1:Opteron_G1:x86_64; 3:AMD Opteron
G2:svm,nx,model_Opteron_G2:Opteron_G2:x86_64; 4:AMD Opteron
G3:svm,nx,model_Opteron_G3:Opteron_G3:x86_64; 5:AMD Opteron
G4:svm,nx,model_Opteron_G4:Opteron_G4:x86_64; 6:AMD Opteron
G5:smx,nx,model_Opteron_G5:Opteron_G5:x86_64; :IBM POWER
7:powernv,model_POWER7_v2.3:POWER 7:ppc64;','3.3');
eli, i think it is ok. ppc is only added to 3.3.
format of the config must be identical to all versions, since the code
splitting it shouldn't have to be made more complex.
Line 424: select fn_db_add_config_value('ServerRebootTimeout','300','general');
Line 425: select
fn_db_add_config_value('SetupNetworksPollingTimeout','3','general');
Line 426: -- Add shareable disk property in vdc_options to support only 3.1
version.
Line 427: select fn_db_add_config_value('ShareableDiskEnabled','false','3.0');
Line 674: select fn_db_update_config_value('PostgresSearchTemplate','SELECT *
FROM (%2$s) %1$s) as T1 %3$s','general');
Line 675: select
fn_db_update_config_value('RhevhLocalFSPath','/data/images/rhev','general');
Line 676: select fn_db_update_config_value('ServerCPUList','3:Intel Conroe
Family:vmx,nx,model_Conroe:Conroe:x86_64; 4:Intel Penryn
Family:vmx,nx,model_Penryn:Penryn:x86_64; 5:Intel Nehalem
Family:vmx,nx,model_Nehalem:Nehalem:x86_64; 6:Intel Westmere
Family:aes,vmx,nx,model_Westmere:Westmere:x86_64; 2:AMD Opteron
G1:svm,nx,model_Opteron_G1:Opteron_G1:x86_64; 3:AMD Opteron
G2:svm,nx,model_Opteron_G2:Opteron_G2:x86_64; 4:AMD Opteron
G3:svm,nx,model_Opteron_G3:Opteron_G3:x86_64;','3.0');
Line 677: select fn_db_update_config_value('ServerCPUList','3:Intel Conroe
Family:vmx,nx,model_Conroe:Conroe:x86_64; 4:Intel Penryn
Family:vmx,nx,model_Penryn:Penryn:x86_64; 5:Intel Nehalem
Family:vmx,nx,model_Nehalem:Nehalem:x86_64; 6:Intel Westmere
Family:aes,vmx,nx,model_Westmere:Westmere:x86_64; 7:Intel SandyBridge
Family:vmx,nx,model_SandyBridge:SandyBridge:x86_64; 2:AMD Opteron
G1:svm,nx,model_Opteron_G1:Opteron_G1:x86_64; 3:AMD Opteron
G2:svm,nx,model_Opteron_G2:Opteron_G2:x86_64; 4:AMD Opteron
G3:svm,nx,model_Opteron_G3:Opteron_G3:x86_64; 5:AMD Opteron
G4:svm,nx,model_Opteron_G4:Opteron_G4:x86_64;','3.1');
Line 678: select fn_db_update_config_value('ServerCPUList','3:Intel Conroe
Family:vmx,nx,model_Conroe:Conroe:x86_64; 4:Intel Penryn
Family:vmx,nx,model_Penryn:Penryn:x86_64; 5:Intel Nehalem
Family:vmx,nx,model_Nehalem:Nehalem:x86_64; 6:Intel Westmere
Family:aes,vmx,nx,model_Westmere:Westmere:x86_64; 7:Intel SandyBridge
Family:vmx,nx,model_SandyBridge:SandyBridge:x86_64; 8:Intel
Haswell:vmx,nx,model_Haswell:Haswell:x86_64; 2:AMD Opteron
G1:svm,nx,model_Opteron_G1:Opteron_G1:x86_64; 3:AMD Opteron
G2:svm,nx,model_Opteron_G2:Opteron_G2:x86_64; 4:AMD Opteron
G3:svm,nx,model_Opteron_G3:Opteron_G3:x86_64; 5:AMD Opteron
G4:svm,nx,model_Opteron_G4:Opteron_G4:x86_64; 6:AMD Opteron
G5:smx,nx,model_Opteron_G5:Opteron_G5:x86_64;','3.2');
well, since it was created above correct, and doesn' t need an update.
though in current format, adding it as an update as well is clearer.
although i understand why its a bug for anyone already deployed with 3.3
pre-release, which will have the entry created and won't get updated to the new
format.
but why are we asking folks to update in both places to begin with? if the
update is updating, why do we need to update the create statements?
wouldn't it be better to separate to two files - create statements and update
statements (unrelated to this patch of course)
Line 679: select
fn_db_update_config_value('SpiceDriverNameInGuest','{"windows": "RHEV-Spice",
"linux" : "xorg-x11-drv-qxl" }','general');
Line 680: select
fn_db_update_config_value('SupportedClusterLevels','3.0,3.1,3.2,3.3','general');
Line 681: select
fn_db_update_config_value('SupportedStorageFormats','0,2,3','3.1,3.2,3.3');
Line 682: select
fn_db_update_config_value('SupportedVDSMVersions','4.9,4.10,4.11,4.12','general');
--
To view, visit http://gerrit.ovirt.org/16700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33ed9231a6467aa59e8f3223ba9d61b6e68039fa
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
