Michael Pasternak has posted comments on this change.
Change subject: core: Initial support for alternative architectures
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
Line 52: if (model.isSetVersion() &&
model.getVersion().getMajor()!=null && model.getVersion().getMinor()!=null) {
Line 53: entity.setcompatibility_version(new
org.ovirt.engine.core.compat.Version(model.getVersion().getMajor(),
Line 54:
model.getVersion().getMinor()));
Line 55: }
Line 56: if (model.isSetArchitecture()) {
please add ValidateEnum to cluster.add()/update() methods
Line 57: Architecture architecture =
Architecture.fromValue(model.getArchitecture());
Line 58: if (architecture != null) {
Line 59: entity.setArchitectureType(map(architecture, null));
Line 60: }
--
To view, visit http://gerrit.ovirt.org/16700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33ed9231a6467aa59e8f3223ba9d61b6e68039fa
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
