Vitor de Lima has posted comments on this change. Change subject: core: Initial support for alternative architectures ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 1178: <xs:element name="threads_as_cores" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1179: <xs:element name="tunnel_migration" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1180: <xs:element name="trusted_service" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1181: <xs:element name="ballooning_enabled" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1182: <xs:element name="architecture" type="xs:string" minOccurs="0" maxOccurs="1"/> Should I export the architecture field in the REST API? I was wondering if it would be better to determine the cluster architecture from its cpu name and don't publicly export this field, since the API user could create a mismatch between the cpu name and the architecture. What do you think about it? Line 1183: <!-- Also a rel="networks" link --> Line 1184: </xs:sequence> Line 1185: </xs:extension> Line 1186: </xs:complexContent> -- To view, visit http://gerrit.ovirt.org/16700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33ed9231a6467aa59e8f3223ba9d61b6e68039fa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
