Shahar Havivi has posted comments on this change.
Change subject: Support for multiple heads for Qxl display device
......................................................................
Patch Set 9: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 392: if (displayType != DisplayType.qxl) {
Line 393:
reasons.add(VdcBllMessages.ACTION_TYPE_FAILED_ILLEGAL_SINGLE_DEVICE_DISPLAY_TYPE.toString());
Line 394: return false;
Line 395: }
Line 396: if (!OsRepositoryImpl.INSTANCE.isLinux(osId)) {
Done
Line 397:
reasons.add(VdcBllMessages.ACTION_TYPE_FAILED_ILLEGAL_SINGLE_DEVICE_OS_TYPE.toString());
Line 398: return false;
Line 399: }
Line 400: return true;
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 63: if (vm.getDisplayType() != vm.getDefaultDisplayType()) {
Line 64: addVideoCardByDisplayType(vm.getDisplayType(),
vm.getNumOfMonitors());
Line 65: }
Line 66: else {
Line 67: addVideoCardsDefinedForVmInDB(vm.getId(),
vm.getSingleQxlPci());
Done
Line 68: }
Line 69: }
Line 70:
Line 71: /**
--
To view, visit http://gerrit.ovirt.org/16803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If18b8ceba3d641f3e2e79947b34b549902f00b55
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
