Tomas Jelinek has posted comments on this change.
Change subject: Support for multiple heads for Qxl display device
......................................................................
Patch Set 11: (5 inline comments)
I have a feel that you miss the setting up the model from template in:
- NewVmModelBehavior
- PoolModelBehaviorBase
And setting the entity from model in:
- PoolListModel
- UserPortalListModel
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
Line 1232: @DefaultStringValue("Migration is NOT currently supported using
SPICE Native USB redirection on cluster version lower than 3.2")
Line 1233: String nativeUsbSupportWarning();
Line 1234:
Line 1235: @DefaultStringValue("Monitors")
Line 1236: String Monitors();
please do not start a method name with uppercase - even in constants.
Line 1237:
Line 1238: @DefaultStringValue("LUN is already in use - attaching it could
cause data corruption.")
Line 1239: String lunAlreadyUsedWarning();
Line 1240:
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
Line 358: public ListModelListBoxEditor<Object> numOfMonitorsEditor;
Line 359:
Line 360: @UiField(provided = true)
Line 361: @Path(value = "isSingleQxlEnabled.entity")
Line 362: @WithElementId("isSingleQxlEnabled.entity")
The element id should be without the ".entity" - the @WithElementId annotation
only generates the IDs of the widgets for automated testing - it is not a
pointer to the model.
Line 363: public EntityModelCheckBoxEditor isSingleQxlEnabledEditor;
Line 364:
Line 365: @UiField(provided = true)
Line 366: @Path(value = "isStateless.entity")
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
Line 152: .monitorsStyles {
Line 153: width: 40px;
Line 154: padding-left: 5px;
Line 155: }
Line 156:
please remove
Line 157: .expanderContent {
Line 158: float: left;
Line 159: }
Line 160:
Line 235: .cdImageEditor {
Line 236: width: 197px;
Line 237: }
Line 238:
Line 239:
please remove
Line 240: .monitorPanel {
Line 241: line-height: 30px;
Line 242: padding-bottom: 0;
Line 243: padding-left: 5px;
Line 245: padding-top: 0;
Line 246: width: 230px;
Line 247: height: 30px;
Line 248: }
Line 249:
please remove
Line 250: .monitorsLabel {
Line 251: float: left;
Line 252: color: #333333;
Line 253: width: 250px;
--
To view, visit http://gerrit.ovirt.org/16803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If18b8ceba3d641f3e2e79947b34b549902f00b55
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
