Omer Frenkel has posted comments on this change.
Change subject: Support for multiple heads for Qxl display device
......................................................................
Patch Set 11: (3 inline comments)
thanks for the fixes, some more minor comments inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
Line 405:
getParameters().getMasterVm().getTunnelMigration(),
Line 406:
getParameters().getMasterVm().getVncKeyboardLayout(),
Line 407:
getParameters().getMasterVm().getMinAllocatedMem(),
Line 408: getParameters().getMasterVm().isStateless(),
Line 409: getParameters().getMasterVm().isRunAndPause(),
missing here copy of the value from the vm to the template,
it would be better to add it to the objects ctors
Line 410: getUserId()));
Line 411:
getVmTemplate().setAutoStartup(getParameters().getMasterVm().isAutoStartup());
Line 412:
getVmTemplate().setPriority(getParameters().getMasterVm().getPriority());
Line 413:
getVmTemplate().setDefaultDisplayType(getParameters().getMasterVm().getDefaultDisplayType());
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 389: }
Line 390:
Line 391: public static boolean isSingleQxlDeviceLegal(DisplayType
displayType, int osId, List<String> reasons,
Line 392: Version compatibilityVersion) {
Line 393: if (!Config.<Boolean>
GetValue(ConfigValues.SingleQxlPciEnabled, compatibilityVersion.getValue())) {
please use FeatureSupported class
Line 394:
reasons.add(VdcBllMessages.ACTION_TYPE_FAILED_ILLEGAL_SINGLE_DEVICE_INCOMPATIBLE_VERSION.toString());
Line 395: return false;
Line 396: }
Line 397: if (displayType != DisplayType.qxl) {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 605: managedDevices.add(vmDevice);
Line 606: }
Line 607: }
Line 608:
Line 609: private static HashMap<String, Object>
getNewMonitorSpecParams(int numOfMonitors) {
this can be called also if display type is vnc, is it ok to send heads here?
Line 610: HashMap<String, Object> specParams = new HashMap<String,
Object>();
Line 611: specParams.put("vram",
String.valueOf(VmDeviceCommonUtils.HIGH_VIDEO_MEM));
Line 612: specParams.put("heads", numOfMonitors);
Line 613: return specParams;
--
To view, visit http://gerrit.ovirt.org/16803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If18b8ceba3d641f3e2e79947b34b549902f00b55
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
