Shahar Havivi has posted comments on this change.
Change subject: Support for multiple heads for Qxl display device
......................................................................
Patch Set 11: (8 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
Line 405:
getParameters().getMasterVm().getTunnelMigration(),
Line 406:
getParameters().getMasterVm().getVncKeyboardLayout(),
Line 407:
getParameters().getMasterVm().getMinAllocatedMem(),
Line 408: getParameters().getMasterVm().isStateless(),
Line 409: getParameters().getMasterVm().isRunAndPause(),
Done
Line 410: getUserId()));
Line 411:
getVmTemplate().setAutoStartup(getParameters().getMasterVm().isAutoStartup());
Line 412:
getVmTemplate().setPriority(getParameters().getMasterVm().getPriority());
Line 413:
getVmTemplate().setDefaultDisplayType(getParameters().getMasterVm().getDefaultDisplayType());
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 389: }
Line 390:
Line 391: public static boolean isSingleQxlDeviceLegal(DisplayType
displayType, int osId, List<String> reasons,
Line 392: Version compatibilityVersion) {
Line 393: if (!Config.<Boolean>
GetValue(ConfigValues.SingleQxlPciEnabled, compatibilityVersion.getValue())) {
Done
Line 394:
reasons.add(VdcBllMessages.ACTION_TYPE_FAILED_ILLEGAL_SINGLE_DEVICE_INCOMPATIBLE_VERSION.toString());
Line 395: return false;
Line 396: }
Line 397: if (displayType != DisplayType.qxl) {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 605: managedDevices.add(vmDevice);
Line 606: }
Line 607: }
Line 608:
Line 609: private static HashMap<String, Object>
getNewMonitorSpecParams(int numOfMonitors) {
Yes,
The default is 1,
But I will add condition for qxl only
Line 610: HashMap<String, Object> specParams = new HashMap<String,
Object>();
Line 611: specParams.put("vram",
String.valueOf(VmDeviceCommonUtils.HIGH_VIDEO_MEM));
Line 612: specParams.put("heads", numOfMonitors);
Line 613: return specParams;
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
Line 1232: @DefaultStringValue("Migration is NOT currently supported using
SPICE Native USB redirection on cluster version lower than 3.2")
Line 1233: String nativeUsbSupportWarning();
Line 1234:
Line 1235: @DefaultStringValue("Monitors")
Line 1236: String Monitors();
Done
Line 1237:
Line 1238: @DefaultStringValue("LUN is already in use - attaching it could
cause data corruption.")
Line 1239: String lunAlreadyUsedWarning();
Line 1240:
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
Line 358: public ListModelListBoxEditor<Object> numOfMonitorsEditor;
Line 359:
Line 360: @UiField(provided = true)
Line 361: @Path(value = "isSingleQxlEnabled.entity")
Line 362: @WithElementId("isSingleQxlEnabled.entity")
Done
Line 363: public EntityModelCheckBoxEditor isSingleQxlEnabledEditor;
Line 364:
Line 365: @UiField(provided = true)
Line 366: @Path(value = "isStateless.entity")
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
Line 152: .monitorsStyles {
Line 153: width: 40px;
Line 154: padding-left: 5px;
Line 155: }
Line 156:
Done
Line 157: .expanderContent {
Line 158: float: left;
Line 159: }
Line 160:
Line 235: .cdImageEditor {
Line 236: width: 197px;
Line 237: }
Line 238:
Line 239:
Done
Line 240: .monitorPanel {
Line 241: line-height: 30px;
Line 242: padding-bottom: 0;
Line 243: padding-left: 5px;
Line 245: padding-top: 0;
Line 246: width: 230px;
Line 247: height: 30px;
Line 248: }
Line 249:
Done
Line 250: .monitorsLabel {
Line 251: float: left;
Line 252: color: #333333;
Line 253: width: 250px;
--
To view, visit http://gerrit.ovirt.org/16803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If18b8ceba3d641f3e2e79947b34b549902f00b55
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
