On Saturday 26 January 2008, Vincent Torri wrote: > > #ifdef HAVE_NETINET_IN_H > > -#include <netinet/in.h> > > -#elif _WIN32 > > -#include <winsock2.h> > > +# include <netinet/in.h> > > +#endif > > +#ifdef HAVE_WINSOCK2_H > > +# include <winsock2.h> > > #endif > > it is completely useless to check it in configure script as winsowk2.h is > always avalaible on windows. So you replace one #ifdef which always works > by a check in configure + a #ifdef. Where is the gain ?
so you dont have to keep adding crap for every random windows related compiler. like the random windows mobile / ce / whatever microsoft puts out. do it once, do it right, and then you're done. > Please, revert what you committed. unless you can show this being incorrect, no -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
