On Fri, Apr 10, 2009 at 7:34 PM, Enlightenment SVN
<no-re...@enlightenment.org> wrote:

>  - now used Eina_List for storage (I hope I used it correct...)

> +   Eina_List *l = NULL;
> +   Evas_Object *o = NULL;
> +
> +   // delete the list
> +   for (l = xscreensaver_list; l; l = eina_list_next(l))
> +   {
> +      xscreensaver_list = eina_list_remove_list(xscreensaver_list, l);
> +   }
> +

please notice:

l = NULL is dead assignment, the first thing you do later is to "l =
xscreensaver_list, so l = NULL is useless and will trigger an alert in
llvm/clang.

EINA_LIST_FOREACH(xscreensaver_list, l, thing)
   code;

would be recommended to iterate over, if to free element it would be:

EINA_LIST_FREE(xscreensaver_list, thing)
    free(thing);

but in your case, you just free the list, so:

xscreensaver_list = eina_list_free(xscreensaver_list);

you can find more examples in eina_list.c and eina_list.h (doxygen).


-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to